Conversation
… w/ different user permissions
…ontrollerFT, rename test too, add null value test
|
Monitor carefully when deploying to production. Follow the release process and manually check that the Streaming Manager and portal are healthy after the release. See https://tools.hmcts.net/confluence/spaces/S28/pages/1958069495/API+release+process for details. |
Co-authored-by: Jason Paige <jasonpaige@users.noreply.github.com> Co-authored-by: 52960 <60659747+hmcts-jenkins-cnp[bot]@users.noreply.github.com> Co-authored-by: Oliver Scott <oliver.scott@justice.gov.uk>
| ); | ||
|
|
||
| if (pageable.getPageNumber() > resultPage.getTotalPages()) { | ||
| throw new RequestedPageOutOfRangeException(pageable.getPageNumber(), resultPage.getTotalPages()); |
Contributor
There was a problem hiding this comment.
When would this scenario happen?
| SELECT 1 FROM PortalAccess pa | ||
| WHERE pa.id = a.createdBy | ||
| AND CONCAT(pa.user.firstName, ' ', pa.user.lastName) ILIKE %:userName%)) | ||
| AND ((CAST(:courtId as uuid) IS NULL AND :caseReference IS NULL) |
Contributor
There was a problem hiding this comment.
I'm not a huge fan of this SQL. I think it's quite....big. And therefore hard to maintain. Is there a way to shift some of this into a Java filter?
lydiaralphgov
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket(s)
Change description